Repository navigation
fix: keep chapter descriptions after hydration - #41
Merged
Merged
Conversation
The VitePress client rewrote meta description to the empty frontmatter description, falling back to the site's, so every rendered page showed the same English text. A markdown-it plugin now writes the description into the frontmatter; the table of contents takes its locale home's. Also give each og:locale:alternate tag an id, since VitePress kept only one meta per key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
<meta name="description">to the page's frontmatter description. That field was empty, so it fell back to the site description, and every rendered page showed the same English sentence. Crawlers that run JS (Google does) saw that sentence instead of the chapter's text.metaper key, so only the lastog:locale:alternatetag survived.SUMMARY.html) had an empty description.Changes
book/.vitepress/seo.mjswrites each page's description into its frontmatter while the page renders. The SSR HTML, the client andog:descriptionnow share that one value. A hand-writtendescription:in frontmatter still wins.og:locale:alternatetag gets its ownid.AGENTS.mddocuments both rules.Verification
SUMMARYpages, which now have one."description":"".ru/grilling.html, after hydration the description is still the chapter's, and bothog:locale:alternatetags (en_US,es_ES) are present.mise run checkpasses.🤖 Generated with Claude Code